Keep GitHub package tags with no release date - #204
Open
codewithfourtix wants to merge 2 commits into
Open
Conversation
Signed-off-by: Ali Zulfiqar <codewithfourtix@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
The new test file should match the repository’s standard license/copyright header convention to keep test modules consistent.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR prevents GitHub tag-to-package conversion from crashing when a tag’s commit date is unavailable/unparseable by allowing release_date to remain unset (None) instead of unconditionally calling strftime().
Changes:
- Handle missing tag commit dates by setting
release_datetoNonerather than callingstrftime()on aNonevalue. - Add a regression test covering a GitHub tag with an unavailable release date.
File summaries
| File | Description |
|---|---|
| tests/test_github_missing_date.py | Adds regression coverage for a tag with a missing commit date. |
| src/fetchcode/package_util.py | Avoids strftime() crash by allowing release_date to be None. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Ali Zulfiqar <codewithfourtix@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub tag helper can return
Nonefor an unavailable or unparseable commit date, but package conversion unconditionally callsstrftime(). Preserve the package with an unset release date instead of crashing.Adds a regression test with a tag whose date is unavailable.